Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/docker): use schema and support annotations #23758

Merged
merged 10 commits into from Aug 31, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 8, 2023

Changes

  • Use zod schema to validate
  • Support manifest annotations as label replacement
  • Support helm configurations to get source url

TODO:

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from zharinov August 8, 2023 12:42
@viceice

This comment was marked as resolved.

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@viceice viceice marked this pull request as ready for review August 30, 2023 08:31
@viceice viceice requested a review from secustor August 30, 2023 08:31
@viceice
Copy link
Member Author

viceice commented Aug 30, 2023

I don't know any docker images or oci helm charts which already have those new annotations. so i could only test the source url findings.

@viceice
Copy link
Member Author

viceice commented Aug 30, 2023

normal docker images still work: renovate-reproductions/23001-oci-helm-chart-metadata#4

so please review 😉

@viceice viceice enabled auto-merge August 31, 2023 09:46
@viceice
Copy link
Member Author

viceice commented Aug 31, 2023

changelogs for oci helm charts are working with this PR 🙃

renovate-reproductions/24144-gitea-changelogs#5

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else LGTM, tough I can not confirm either if the media types are correct

lib/modules/datasource/docker/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@viceice
Copy link
Member Author

viceice commented Aug 31, 2023

Else LGTM, tough I can not confirm either if the media types are correct

The media types are the same as before and i validated them against existing objects and docs

@viceice viceice requested a review from secustor August 31, 2023 10:30
@viceice viceice added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 2b24509 Aug 31, 2023
36 checks passed
@viceice viceice deleted the feat/docker-annotations branch August 31, 2023 11:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants