Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(woodpecker): Adding woodpecker v1.x support #23838

Merged
merged 10 commits into from Aug 29, 2023
Merged

feat(woodpecker): Adding woodpecker v1.x support #23838

merged 10 commits into from Aug 29, 2023

Conversation

ramigoldvarg
Copy link
Contributor

Changes

Adding woodpecker V1.0.x support.

Context

Closes #23574

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ramigoldvarg ramigoldvarg changed the title Adding woodpecker v1.x support feat(woodpecker): Adding woodpecker v1.x support Aug 12, 2023
viceice
viceice requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLA issue please fix git author/ committer and force push branch

viceice
viceice reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/woodpecker/extract.spec.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See open discussion

@viceice
Copy link
Member

viceice commented Aug 25, 2023

please don't force push

https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

@viceice
Copy link
Member

viceice commented Aug 25, 2023

please don't force push

https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

☝️

@viceice
Copy link
Member

viceice commented Aug 25, 2023

please check the manager readme.md. Are the links all valid? should we mention the new v1 supprt?

@viceice
Copy link
Member

viceice commented Aug 25, 2023

please don't force push
https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

☝️

@ramigoldvarg ☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️

@ramigoldvarg
Copy link
Contributor Author

please don't force push
https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

☝️

@ramigoldvarg ☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️

I used the gihub button :(

@ramigoldvarg
Copy link
Contributor Author

please check the manager readme.md. Are the links all valid? should we mention the new v1 supprt?

I think so, yes

@viceice
Copy link
Member

viceice commented Aug 25, 2023

please don't force push
https://github.com/renovatebot/renovate/blob/main/.github/contributing.md

☝️

@ramigoldvarg ☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️☝️

I used the gihub button :(

Use merge instead of rebase

viceice
viceice previously approved these changes Aug 25, 2023
View reviewed changes
@viceice viceice enabled auto-merge August 29, 2023 18:17
@viceice viceice added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@rarkins rarkins enabled auto-merge August 29, 2023 19:27
@rarkins rarkins added this pull request to the merge queue Aug 29, 2023
Merged via the queue into renovatebot:main with commit 3dbbc0a Aug 29, 2023
35 of 36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@viceice viceice viceice approved these changes

@Giangpro89 Giangpro89 Giangpro89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Woodpecker v1
6 participants
@ramigoldvarg @CLAassistant @viceice @renovate-release @rarkins @Giangpro89