Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-submodules): take git-tags and git-refs hostRules into account #24250

Merged
merged 2 commits into from Sep 28, 2023

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Sep 5, 2023

Changes

This PR adds support for two extra hostTypes when looking up the defeault branch for git-submodules as well as when updating git-submodules. This allows users to define hostRules independent of the hostType via the already existing rules for git-tags and git-refs used by the same datasources.

I tested this change against a private GitLab instance with a Renovate token for only the "parent" repository and adding an extra hostRule like this to allow for access to the private submodule:

{
 hostRules:[
    {
      hostType: "git-refs",
      matchHost: "gitlab.int",
      username: "oauth2",
      password: "subModuleToken"
    },
    {
      hostType: "git-tags",
      matchHost: "gitlab.int",
      username: "oauth2",
      password: "subModuleToken"
    }
}

Context

Fixes #24077

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Sep 28, 2023

@Shegox ready for review/merge?

@Shegox Shegox marked this pull request as ready for review September 28, 2023 11:27
@Shegox
Copy link
Contributor Author

Shegox commented Sep 28, 2023

@rarkins should be ready, although no longer needed in addressing #24077 as I first though, but might be helpful non the less

@rarkins rarkins added this pull request to the merge queue Sep 28, 2023
Merged via the queue into renovatebot:main with commit 5f82d9d Sep 28, 2023
36 checks passed
@Shegox Shegox deleted the submodule-gitrefs-gittags branch September 28, 2023 12:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants