Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datasource/docker): promote ECR auth errors to warnings #24521

Merged
merged 1 commit into from Sep 28, 2023

Conversation

colinodell
Copy link
Contributor

@colinodell colinodell commented Sep 19, 2023

Changes

This PR increases the log level of ECR getAuthorizationToken error messages from debug to warning.

Context

These errors can occur for various reasons, such as configuring invalid or expired credentials. If we can't get an auth token, all attempts to update those dependencies will fail. We should therefore consider bumping up the log level to make these errors more visible.

This change also aligns with the log level used just a few lines above on line 34 (different type of error within the same function):

const ecr = new ECR(config);
try {
const data = await ecr.getAuthorizationToken({});
const authorizationToken = data?.authorizationData?.[0]?.authorizationToken;
if (authorizationToken) {
// sanitize token
addSecretForSanitizing(authorizationToken);
return authorizationToken;
}
logger.warn(
'Could not extract authorizationToken from ECR getAuthorizationToken response'
);
} catch (err) {
logger.trace({ err }, 'err');
logger.debug('ECR getAuthorizationToken error');
}
return null;

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title feat(datasource/docker): promote ECR auth errors to warnings chore(datasource/docker): promote ECR auth errors to warnings Sep 28, 2023
@rarkins rarkins added this pull request to the merge queue Sep 28, 2023
Merged via the queue into renovatebot:main with commit f58cb01 Sep 28, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants