Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipenv): add support for auth #24581

Merged
merged 26 commits into from Nov 14, 2023
Merged

feat(pipenv): add support for auth #24581

merged 26 commits into from Nov 14, 2023

Conversation

maxromanovsky
Copy link
Contributor

@maxromanovsky maxromanovsky commented Sep 21, 2023 •
edited by viceice

Changes

Implements #24541

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

rarkins
rarkins requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good! Needs:

  • Confirmation that it's working with a "real" repo
  • Unit test additions for coverage

@maxromanovsky maxromanovsky marked this pull request as ready for review September 28, 2023 16:40
viceice
viceice reviewed Sep 29, 2023
View reviewed changes
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@rarkins rarkins changed the title feat: add support for pipenv auth feat(pipenv): add support for auth Sep 29, 2023
@maxromanovsky
Copy link
Contributor Author

@viceice @rarkins Please re-review when you have some time. I hope I fixed all your very valid points.
Thanks for your feedback!

@viceice
Copy link
Member

viceice commented Oct 12, 2023

use re-request review button besides the reviewers

viceice
viceice reviewed Oct 16, 2023
View reviewed changes
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@maxromanovsky
Copy link
Contributor Author

@rarkins please let me know what needs to be done to merge this PR. Thanks in advance.

rarkins
rarkins requested changes Nov 13, 2023
View reviewed changes
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Nov 14, 2023
Merged via the queue into renovatebot:main with commit 8401943 Nov 14, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maxromanovsky maxromanovsky deleted the feat/24541-support-pipenv-auth branch November 21, 2023 11:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipenv: Support USERNAME and PASSWORD auth when updating artifcacts
5 participants
@maxromanovsky @CLAassistant @viceice @renovate-release @rarkins