feat(datasource/maven): Add Artifact Registry support via Google ADC #24657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvanzuijlen
changed the title
|
@kvanzuijlen is this ready for review? |
|
Somehow it passes coverage. @zharinov is this possibly a bug in our sharded tests? |
|
I think the coverage check was skipped? |
|
Yes you're right - due to it being a draft PR |
… into maven-artifact-registry-support
rarkins
changed the title
Churro
suggested changes
Oct 1, 2023
Churro
suggested changes
Oct 2, 2023
|
Thank you so much for taking the time to review my PR @Churro |
Churro
suggested changes
Oct 3, 2023
Churro
suggested changes
Oct 6, 2023
Churro
reviewed
Oct 6, 2023
Co-authored-by: Johannes Feichtner <343448+Churro@users.noreply.github.com>
Churro
suggested changes
Oct 7, 2023
Churro
approved these changes
Oct 7, 2023
rarkins
approved these changes
Oct 15, 2023
|
🎉 This PR is included in version 37.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds Google Application Default Credentials (ADC)/Workload Identity support for Maven repositories
Context
This change makes configuring Artifact Registry support easier and makes use of best practices.
Documentation (please check one with an [x])
How I've tested my work (please select one)
@viceice My proposal for writing unit tests for this change is to add tests to the
downloadMavenXmlblock and add a new block to specifically testdownloadArtifactRegistryProtocol. Do you agree with this proposal?I have verified these changes via: