Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): validate reconfigure branch #24699

Merged
merged 38 commits into from Nov 3, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Implement validation of reconfigure branch

Context

Closes: #13948

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh

This comment was marked as outdated.

@RahulGautamSingh
Copy link
Collaborator Author

Since we do not control the creation of this branch, shuold we ignore while pruning stale branches?

@rarkins
Copy link
Collaborator

rarkins commented Sep 29, 2023

yes, we should ignore it when pruning

lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Oct 3, 2023

Test runs:

On re-runs there was no cloning, tested it locally.

lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Oct 4, 2023

Also needs docs added

lib/workers/repository/reconfigure/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/reconfigure-cache.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/reconfigure-cache.ts Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/reconfigure-cache.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits October 4, 2023 17:51
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
RahulGautamSingh and others added 2 commits October 23, 2023 04:04
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins changed the title feat: validate reconfigure branch feat(config): validate reconfigure branch Oct 23, 2023
docs/usage/config-validation.md Outdated Show resolved Hide resolved
lib/workers/repository/reconfigure/index.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits October 27, 2023 04:52
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Oct 27, 2023

Re-run the tests for confirmation, All working ✅

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarkins rarkins added this pull request to the merge queue Nov 3, 2023
Merged via the queue into renovatebot:main with commit 32340db Nov 3, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger renovate-bot to check the syntax of renovate configuration on PRs
6 participants