Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo): support private crate #24704

Merged
merged 9 commits into from Oct 3, 2023

Conversation

vmaerten
Copy link
Contributor

Changes

For the Cargo manager, I've enabled by default net.git-fetch-with-cli.
I also enable hostRule for passing token to pull private crate (like it's done for Golang)

Context

Closes #20059
Cargo, in Renovate, could not pull private crate when updating artifacts.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

I've updated the snapshot to see the new Cargo config, and I tested it locally pointing to a repo with a private crate.

It's my first PR, I hope I did not miss something.

rarkins
rarkins previously approved these changes Oct 1, 2023
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry in in cargo/index.md that this is happening.

lib/modules/manager/cargo/artifacts.ts Outdated Show resolved Hide resolved
@vmaerten
Copy link
Contributor Author

vmaerten commented Oct 2, 2023

Thanks for your review!
I've updated the doc in cargo/readme.md, following the same convention as for golang (gomod/readme.md)
I've also added 3 tests to ensure that env variable are applied

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review, needs more work after.

docs/usage/rust.md Outdated Show resolved Hide resolved
docs/usage/rust.md Outdated Show resolved Hide resolved
docs/usage/rust.md Outdated Show resolved Hide resolved
lib/modules/manager/cargo/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/cargo/readme.md Outdated Show resolved Hide resolved
vmaerten and others added 2 commits October 2, 2023 08:41
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@vmaerten
Copy link
Contributor Author

vmaerten commented Oct 2, 2023

@HonkingGoose I've applied your suggestions.
I also tried to rephase the self hosted part.

rarkins
rarkins previously approved these changes Oct 2, 2023
docs/usage/rust.md Outdated Show resolved Hide resolved
docs/usage/rust.md Outdated Show resolved Hide resolved
docs/usage/rust.md Outdated Show resolved Hide resolved
lib/modules/manager/cargo/readme.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs, but I want a maintainer to review the left and right side of the Markdown diff. I suspect we're accidentally dropping some information.

@vmaerten vmaerten requested a review from rarkins October 3, 2023 09:14
@secustor secustor added this pull request to the merge queue Oct 3, 2023
Merged via the queue into renovatebot:main with commit 3c592a2 Oct 3, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private rust/Cargo repositories artifacts update support
5 participants