Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versionCompatibility): fix compatibility suffix #24954

Merged
merged 7 commits into from Oct 2, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 2, 2023

Changes

Pass the parsed/extracted value to getNewValue instead of the full value

Context

Enables things like debian codenames + -slim

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title docs(versionCompatibility): fix compatibility suffix example fix(versionCompatibility): fix compatibility suffix Oct 2, 2023
@rarkins rarkins marked this pull request as ready for review October 2, 2023 12:48
Base automatically changed from refactor/new-value-type to main October 2, 2023 13:15
@rarkins rarkins requested a review from viceice October 2, 2023 13:22
@rarkins rarkins added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit e6fdecd Oct 2, 2023
36 checks passed
@rarkins rarkins deleted the fix/version-compatbility-value branch October 2, 2023 13:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants