Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support extracting buildkite plugins from Bitbucket Cloud #24980

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

peter-svensson
Copy link
Contributor

@peter-svensson peter-svensson commented Oct 3, 2023

Changes

Add support for extracting buildkite plugin tag information from Bitbucket Cloud as well as from Github.

Context

Since Buildkite plugins might be self-hosted (or on a another provider than Github.com), in this particular case Bitbucket Cloud, all created Pull Requests contains warnings about missing dependency information.

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Oct 3, 2023
lib/modules/manager/buildkite/extract.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2023

@peter-svensson thanks for the PR! Can you share the "real repository" you tested again so we can validate it's working as intended?

@peter-svensson
Copy link
Contributor Author

@peter-svensson thanks for the PR! Can you share the "real repository" you tested again so we can validate it's working as intended?

I did some initial testing on private repositories but I set up a public minimal example here: https://bitbucket.org/sparetimecoders/renovate-test

lib/modules/manager/buildkite/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge October 3, 2023 10:03
@rarkins rarkins added this pull request to the merge queue Oct 3, 2023
Merged via the queue into renovatebot:main with commit 6f4c389 Oct 3, 2023
36 checks passed
@peter-svensson peter-svensson deleted the buildkite_bitbucket branch October 3, 2023 10:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants