Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lookup): include package name in warning message #24998

Merged
merged 1 commit into from Oct 4, 2023

Conversation

colinodell
Copy link
Contributor

Changes

Revises the warning message to ensure the affected package name is shown to end users.

Context

This warning message is currently presented to end users like this:

image

Note that users aren't told which package(s) are the culprit. Finding that out requires access to Renovate's logging.

I therefore propose we include the package name in the warning, just like we do for all other warning messages:

const warning: ValidationMessage = {
topic: config.packageName,
message: `Failed to look up ${config.datasource} package ${config.packageName}`,
};
logger.debug(
{
dependency: config.packageName,
packageFile: config.packageFile,
},
warning.message
);
// TODO: return warnings in own field
res.warnings.push(warning);

res.warnings.push({
topic: config.packageName,
message: `Can't find version with tag ${config.followTag} for ${config.datasource} package ${config.packageName}`,
});

res.warnings.push({
topic: config.packageName,
// TODO: types (#22198)
message: `Can't find version matching ${compareValue!} for ${
config.datasource
} package ${config.packageName}`,
});

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Oct 4, 2023
Merged via the queue into renovatebot:main with commit 6aaf8df Oct 4, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

cdloh added a commit to cdloh/renovate that referenced this pull request Oct 5, 2023
… into feat/add-ubuntu-container-support

* fork/feat/add-ubuntu-container-support:
  fix(npm): re-enable lock file maintenance (renovatebot#25045)
  chore: drop `status:ready` and improve triage docs (renovatebot#25023)
  fix(go): Ignore `mod` type of `go-import` header (renovatebot#25039)
  chore(deps): update dependency @types/moo to v0.5.7 (renovatebot#25031)
  feat(terraform-module): always use 'source' as sourceUrl when available (renovatebot#25008)
  chore(deps): update dependency @types/mdast to v3.0.13 (renovatebot#25027)
  build(deps): update dependency @types/ms to v0.7.32 (renovatebot#25026)
  chore: drop `priority-5-triage` label (renovatebot#25024)
  chore(lookup): include package name in warning message (renovatebot#24998)
  chore: allow null value and undefined for validateURL (renovatebot#25014)
  fix: add httpsCertificate, httpsPrivateKey and httpsCertificateAuthority into redactedFields (renovatebot#25013)
  chore(deps): update dependency type-fest to v4.3.3 (renovatebot#25011)
  chore(deps): update dependency @types/markdown-it to v13.0.2 (renovatebot#25010)
  build(deps): update dependency zod to v3.22.3 [security] (renovatebot#25007)
  chore(deps): update dependency type-fest to v4.3.2 (renovatebot#25006)
  build(deps): update dependency markdown-it to v13.0.2 (renovatebot#25005)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants