Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): automatic ghcr.io auth when using github.com #25017

Merged
merged 10 commits into from Oct 9, 2023
Merged

feat(github): automatic ghcr.io auth when using github.com #25017

merged 10 commits into from Oct 9, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 4, 2023

Changes

Context

Closes #25016

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins commented Oct 4, 2023
View reviewed changes
lib/modules/platform/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 4, 2023 •
edited

Needs these tests:

  • Public and private images with PAT with correct permissions
  • Public image with PAT with no read:packages permission
  • Public and private images with app token with correct permissions
  • Public and private images with app token missing package permissions

Perhaps best to make this experimental feature flagged for opting in, then make it default but with feature flag for opting out, until we're fully sure?

@rarkins rarkins marked this pull request as ready for review October 8, 2023 13:18
@rarkins @viceice
Update lib/modules/platform/types.ts
f155f30 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice October 9, 2023 13:33
viceice
viceice reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/platform/types.ts Outdated Show resolved Hide resolved
@rarkins @viceice
Update types.ts
fff8423 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice October 9, 2023 15:47
viceice
viceice previously approved these changes Oct 9, 2023
View reviewed changes
secustor
secustor reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else lgtm

lib/modules/platform/index.spec.ts Outdated Show resolved Hide resolved
@rarkins @secustor
Update lib/modules/platform/index.spec.ts
1097276 
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@rarkins rarkins enabled auto-merge October 9, 2023 16:22
@secustor
Copy link
Collaborator

secustor commented Oct 9, 2023

Needs prettier fixes

viceice
viceice previously approved these changes Oct 9, 2023
View reviewed changes
@rarkins rarkins requested a review from viceice October 9, 2023 16:39
@rarkins rarkins added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 22709f4 Oct 9, 2023
36 checks passed
@rarkins rarkins deleted the feat/25016-ghcr-automatic-auth branch October 9, 2023 20:56
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomachristian tomachristian tomachristian left review comments

@secustor secustor secustor approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support automatic ghcr.io authentication using github.com token
5 participants
@rarkins @secustor @renovate-release @tomachristian @viceice