feat(changelog): improve release detection #25050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Oct 8, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zharinov
suggested changes
Oct 9, 2023
zharinov
reviewed
Oct 9, 2023
lib/workers/repository/update/pr/changelog/__snapshots__/releases.spec.ts.snap
Outdated
Show resolved
Hide resolved
6 tasks
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
…ses.spec.ts.snap Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
viceice
previously approved these changes
Oct 16, 2023
|
needs prettier run |
viceice
approved these changes
Oct 16, 2023
viceice
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This PR is included in version 37.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ran into a bug where if we have a pinned version that does not exist then it skips over checking for changelogs.
i.e pinning to 1.2.3 but only 1.2.4, 1.2.2 exists
Noticed there is a chunk of code here https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/update/pr/changelog/source.ts#L101 that enforces two releases minimum, due to how it extracts changelog diffs between two versions.
This pr just adds logic to try and best guess what the last version should have been so that changelogs still work as expected, or rather there will be 2 releases to perform the changelog
see phyzical/renovate-tester#10 for an example where it is working with these changes.
Or rather goodwithtech/dockle@v0.4.11...v0.4.13 you can see that is has produced a diff via 0.4.11 -> 0.4.13 even though its pinned to 0.4.12
and see #25043 for more information of my debugging
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: