Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): Add support for Go host code.cloudfoundry.org #25173

Merged
merged 2 commits into from Oct 13, 2023

Conversation

silvestre
Copy link
Contributor

Changes

Dependency updates for Go libraries from code.cloudfoundry.org are now supported.

Context

In #18246 it was discussed that the error message

Unsupported go host - cannot look up versions

is not a bug when using Go dependencies from code.cloudfoundry.org, however in our daily work on app-autoscaler-release it is unfortunate such dependencies are not automatically updated by Renovate

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

## Changes

Dependency updates for Go libraries from `code.cloudfoundry.org` are now supported.

## Context

In renovatebot#18246 it was discussed that the error message
```
Unsupported go host - cannot look up versions
```

is not a bug when using Go dependencies from `code.cloudfoundry.org`,
however in our daily work on `app-autoscaler-release` it is unfortunate
[such dependencies are not automatically updated by Renovate](cloudfoundry/app-autoscaler-release#1100)

## Documentation (please check one with an [x])

- [ ] I have updated the documentation, or
- [x] No documentation update is required

## How I've tested my work (please select one)

I have verified these changes via:

- [ ] Code inspection only, or
- [ ] Newly added/modified unit tests, or
- [ ] No unit tests but ran on a real repository, or
- [x] Both unit tests + ran on a real repository
Do not use `split`, just replace the prefix
@rarkins rarkins added this pull request to the merge queue Oct 13, 2023
Merged via the queue into renovatebot:main with commit 9c8e6ac Oct 13, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants