Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pep621): support hatch environments #25211

Merged

Conversation

jonathanberthias
Copy link
Contributor

Changes

This PR extends the PEP621 manager to add support for updating dependencies specified in hatch environments.

This work builds on top of #22082 by adding a new processor. Note that hatch does not have lock files.

Context

Closes #24956.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor self-requested a review October 15, 2023 06:51
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of the lint errors

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run pnpm test to do a full acceptance test

lib/modules/manager/pep621/processors/hatch.ts Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@jonathanberthias
Copy link
Contributor Author

Run pnpm test to do a full acceptance test

For some reason it gets stuck forever at the eslint step 🤷

lib/modules/manager/pep621/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pep621/processors/hatch.ts Outdated Show resolved Hide resolved
lib/modules/manager/pep621/processors/hatch.ts Outdated Show resolved Hide resolved
jonathanberthias and others added 2 commits October 16, 2023 11:23
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@secustor secustor added this pull request to the merge queue Oct 16, 2023
Merged via the queue into renovatebot:main with commit 98dccff Oct 16, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants