Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(best practices): refactor code or tests, not both at once #25237

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Oct 16, 2023

Changes

  • Explain that you should refactor the tests or the code, but not both

Context

@rarkins and @zharinov have a unwritten refactoring rule: 1

OK so I believe you are describing a kind of unwritten refactoring rule which @zharinov and I have, which is: refactor the code, or refactor the tests - but avoid refactoring both at the same time or you can accidentally mask regression errors

This rule should be explained in our developing docs. 😉

Related to issue:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Footnotes

  1. https://github.com/renovatebot/renovate/issues/25106#issuecomment-1759310483

@rarkins rarkins added this pull request to the merge queue Oct 17, 2023
Merged via the queue into renovatebot:main with commit afa289f Oct 17, 2023
36 checks passed
@HonkingGoose HonkingGoose deleted the docs/25106-refactor-test-or-code-not-both branch October 17, 2023 08:28
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants