New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelogs): Migrate fetchReleaseNotes to fetchChangeLogs #25364
feat(changelogs): Migrate fetchReleaseNotes to fetchChangeLogs #25364
Conversation
* Add migration from fetchReleaseNotes to fetchChangeLogs * remove isDeprecated * Remove old migration
I think this 2 issue in scope of this PR |
lib/config/migrations/custom/fetch-release-notes-migration.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs migration of env and CLI params too, otherwise to wait for a major release
rarkins I can't see in the documentation that we can add migration for fetchReleaseNotes as CLI parameter or ENV variable after testing. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs testing on a real repository
Hi @rarkins It was tested on its repos in azure devops. Run from the local machine
|
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my new suggestions would make the code cleaner
Thanks @viceice |
…to-change-logs # Conflicts: # docs/usage/self-hosted-configuration.md
🎉 This PR is included in version 37.46.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…atebot#25364) Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: