Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelogs): Migrate fetchReleaseNotes to fetchChangeLogs #25364

Merged

Conversation

illay1994
Copy link
Contributor

@illay1994 illay1994 commented Oct 24, 2023

  • Add migration from fetchReleaseNotes to fetchChangeLogs
  • remove isDeprecated
  • Remove old migration

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

* Add migration from fetchReleaseNotes to fetchChangeLogs
* remove isDeprecated
* Remove old migration
@illay1994 illay1994 mentioned this pull request Oct 24, 2023
6 tasks
@illay1994 illay1994 changed the title Migrate fetchReleaseNotes to fetchChangeLogs feat: Migrate fetchReleaseNotes to fetchChangeLogs Oct 24, 2023
@illay1994
Copy link
Contributor Author

I think this 2 issue in scope of this PR

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/migrations/migrations-service.ts Outdated Show resolved Hide resolved
lib/config/migrations/migrations-service.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs migration of env and CLI params too, otherwise to wait for a major release

@illay1994
Copy link
Contributor Author

illay1994 commented Oct 25, 2023

rarkins I can't see in the documentation that we can add migration for fetchReleaseNotes as CLI parameter or ENV variable after testing.
I will test and add if it is required

image

@illay1994
Copy link
Contributor Author

image
Hi @rarkins
Look like we don't need any extra migrations

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs testing on a real repository

@illay1994
Copy link
Contributor Author

Hi @rarkins

It was tested on its repos in azure devops.
Please review screenshots.

Run from the local machine

pnpm start --platform=azure --endpoint=https://dev.azure.com/organization --token=PAT reponame

image
Screenshot 2023-10-28 124605

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins changed the title feat: Migrate fetchReleaseNotes to fetchChangeLogs feat(changelogs): Migrate fetchReleaseNotes to fetchChangeLogs Oct 30, 2023
rarkins
rarkins previously approved these changes Oct 30, 2023
@rarkins rarkins requested a review from viceice October 30, 2023 14:08
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my new suggestions would make the code cleaner

@illay1994
Copy link
Contributor Author

Thanks @viceice
Supper nice comments.

…to-change-logs

# Conflicts:
#	docs/usage/self-hosted-configuration.md
@rarkins rarkins added this pull request to the merge queue Nov 5, 2023
Merged via the queue into renovatebot:main with commit f70f0c8 Nov 5, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@illay1994 illay1994 deleted the migrate-releasenotes-to-change-logs branch November 5, 2023 19:31
jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
…atebot#25364)

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants