Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Reduce constraints changes in lockfiles #25430

Merged
merged 8 commits into from Nov 2, 2023
Merged

fix(terraform): Reduce constraints changes in lockfiles #25430

merged 8 commits into from Nov 2, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Oct 25, 2023 •
edited

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as ready for review October 30, 2023 22:55
@zharinov zharinov changed the title fix(terraform): Reduce constraints changes fix(terraform): Reduce constraints changes in lockfiles Oct 31, 2023
viceice
viceice reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I think this needs real repo tests

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 2, 2023

Examples:

@zharinov zharinov requested a review from viceice November 2, 2023 11:10
@rarkins rarkins added this pull request to the merge queue Nov 2, 2023
Merged via the queue into renovatebot:main with commit a7faacc Nov 2, 2023
36 checks passed
@rarkins rarkins deleted the fix/terraform-25193-terraform-constraints-reduction branch November 2, 2023 12:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@zharinov @rarkins @jon4hz
fix(terraform): Reduce constraints changes in lockfiles (renovatebot#…
b479c10 
…25430)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor left review comments

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform: reduce constraints changes
5 participants
@zharinov @renovate-release @viceice @rarkins @secustor