refactor(errors): massaging validation messages before we assign it #25452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipAbed
changed the title
viceice
reviewed
Oct 30, 2023
viceice
reviewed
Oct 31, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Oct 31, 2023
|
🎉 This PR is included in version 37.37.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
…enovatebot#25452) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reformatted the
validationMessageto massage the message before assigning it to theerrors.validationMessageso that we can put Links and mark words with code style.
also swapped the
matchConfidencevalidationError with the validationMessage, (it was like this because it was all into codestyle and we couldnt put links in it, so it was swapped)Context
we are having trouble assigning Links and marking words in code style in error messages.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: