Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "build(deps): update opentelemetry-js monorepo (#25262)" #25473

Merged
merged 1 commit into from Oct 27, 2023

Conversation

gizero
Copy link
Contributor

@gizero gizero commented Oct 27, 2023

See #25464 for context.

This reverts commit 2cc19e8.

Changes

Rolls back a dependency update (opentelemetry-js monorepo) that broke renovate capability to export traces to OTEL otel-collector. The issue is known in the upstream project and the rollback provided by this PR restores the expected behaviour at least until after a fix is made available upstream.

No behaviour change other than restoring the ability to send OTEL traces.

Context

This is a dependency upgrade rollback.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

pnpm install --frozen-lockfile
pnpm run build
OTEL_EXPORTER_OTLP_ENDPOINT=http://127.0.0.1:4318 LOG_LEVEL=debug \ RENOVATE_TRACING_CONSOLE_EXPORTER=true pnpm start --dry-run --platform gitlab \
--token <redacted> --endpoint https://my.self.hosted.instance/api/v4 path/to/testrepo

With this rollback applied traces are being sent to the collector while running the same test on current main branch fails while trying to send traces with this log:

{
  traceId: 'd596fd8fb6ee973230ef8ea70a28bf18',
  parentId: undefined,
  traceState: undefined,
  name: 'run',
  id: 'e86ec58dfa109acf',
  kind: 0,
  timestamp: 1698424357466000,
  duration: 7351537.977,
  attributes: {},
  status: { code: 0 },
  events: [],
  links: []
}
ERROR: unhandledRejection
       "err": {
         "name": "OTLPExporterError",
         "data": "{\"code\":3,\"message\":\"ReadUint64: unsupported value type, error found in #10 byte of ...|UnixNano\\\":{\\\"low\\\":179|..., bigger context ...|55\\\",\\\"name\\\":\\\"extract\\\",\\\"kind\\\":1,\\\"startTimeUnixNano\
\\":{\\\"low\\\":1794030848,\\\"high\\\":395445237},\\\"endTimeUnixNa|...\"}",
         "code": 400,
         "message": "Bad Request",
         "stack": "OTLPExporterError: Bad Request\n    at IncomingMessage.<anonymous> (/Users/gizero/work/src/renovate/node_modules/.pnpm/@opentelemetry+otlp-exporter-base@0.44.0_@opentelemetry+api@1.6.0/node_modules/@opentelemetry/otlp-e
xporter-base/src/platform/node/util.ts:131:27)\n    at /Users/gizero/work/src/renovate/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.17.1_@opentelemetry+api@1.6.0/node_modules/@opentelemetry/context-async-hooks/src/AbstractAsync
HooksContextManager.ts:75:49\n    at AsyncLocalStorage.run (node:async_hooks:330:14)\n    at AsyncLocalStorageContextManager.with (/Users/gizero/work/src/renovate/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.17.1_@opentelemetry
+api@1.6.0/node_modules/@opentelemetry/context-async-hooks/src/AsyncLocalStorageContextManager.ts:40:36)\n    at IncomingMessage.contextWrapper (/Users/gizero/work/src/renovate/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.17.1_
@opentelemetry+api@1.6.0/node_modules/@opentelemetry/context-async-hooks/src/AbstractAsyncHooksContextManager.ts:75:26)\n    at IncomingMessage.emit (node:events:525:35)\n    at IncomingMessage.emit (node:domain:489:12)\n    at endReadabl
eNT (node:internal/streams/readable:1359:12)\n    at processTicksAndRejections (node:internal/process/task_queues:82:21)"
       }

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

@rarkins rarkins added this pull request to the merge queue Oct 27, 2023
Merged via the queue into renovatebot:main with commit 18fd654 Oct 27, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.34.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gizero gizero deleted the rollback-opentelemetry-js-monorepo branch October 27, 2023 20:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants