Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update re2 to 1.20.5 #25483

Merged
merged 2 commits into from Oct 29, 2023
Merged

build(deps): update re2 to 1.20.5 #25483

merged 2 commits into from Oct 29, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 28, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@illay1994
Copy link
Contributor

@rarkins
Could you please try to add next code into lib\util\regex.tf?

if flags is undefined
const instance = new RegEx(pattern);
else
const instance = new RegEx(pattern, flags);

uhop/node-re2@5cf9f40#diff-823c59b7169179de81ed14b9991341fe52e0e47dd6cf887485f1f756681b8686
looks like this commit broke logic when pattern \abac\g and flags undefined

viceice
viceice previously approved these changes Oct 28, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't renovate already show this update as pending on dashboard? 🤔

@rarkins rarkins added this pull request to the merge queue Oct 29, 2023
Merged via the queue into main with commit 09c2a6a Oct 29, 2023
36 checks passed
@rarkins rarkins deleted the build/re-2-1.20.5 branch October 29, 2023 06:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants