Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): add support for Kotlin import directives #25486

Merged
merged 2 commits into from Oct 28, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Oct 28, 2023

Changes

Adds functionality to resolve variables that are referenced via Kotlin import statements.

This PR adds a parser pattern for import statements and stores the corresponding object declarations, classes, etc. If variables cannot be resolved in the local or global context, it is checked whether they were imported by assembling a matching location. The order of checking (local context first) is important because variables could be overwritten after importing.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: renovate-demo/25373-renovate-gradle-issue#2

@viceice viceice added this pull request to the merge queue Oct 28, 2023
Merged via the queue into renovatebot:main with commit a57cdfd Oct 28, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants