Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workers/branchName): template groupName before slugging #25490

Merged

Conversation

secustor
Copy link
Collaborator

Changes

templates groupNamebefore slugging it.
This is to prevent accidental grouping if groupName is set to a template

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/opentelemetry-demo/pulls

@secustor secustor added this pull request to the merge queue Oct 29, 2023
Merged via the queue into renovatebot:main with commit 50e3f82 Oct 29, 2023
36 checks passed
@secustor secustor deleted the fix/template-groupName-before-slugging branch October 29, 2023 18:06
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.35.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants