Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AWS SDK monorepo preset #25508

Merged
merged 2 commits into from Nov 2, 2023
Merged

feat: add AWS SDK monorepo preset #25508

merged 2 commits into from Nov 2, 2023

Conversation

Isawan
Copy link
Contributor

@Isawan Isawan commented Oct 31, 2023

Changes

Adds support for AWS SDK monorepo grouping for rust projects

Context

AWS has multiple SDKs which are frequently updated together, this allows the AWS SDK updates to be grouped together. This is equivalent to the current functionality implemented for the .NET and javascript SDK.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • [ x] No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • [x ] Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Note: I'm upstreaming a similar config I currently use on a project of mine. Example PR

@Isawan Isawan changed the title feat: Added AWS SDK Monorepo preset feat: add AWS SDK monorepo preset Nov 1, 2023
@HonkingGoose
Copy link
Collaborator

@Isawan I see you're making this change on your fork's main branch. The next time, you should create a new branch on your fork 1, and put your work in there.

After your PR is reviewed and merged, you can fix your fork's main branch by using the Sync fork button 2 in the GitHub UI.

Footnotes

  1. GitHub Docs, Creating a branch

  2. GitHub Docs, syncing a fork

@Isawan
Copy link
Contributor Author

Isawan commented Nov 2, 2023

Are we ok to continue with this PR? I'll reset my main branch once this is merged. Alternatively, I can re-open the PR from a separate branch.

@rarkins rarkins added this pull request to the merge queue Nov 2, 2023
Merged via the queue into renovatebot:main with commit 0a9945e Nov 2, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Isawan added a commit to Isawan/terrashine that referenced this pull request Nov 2, 2023
This has been upstreamed to renovate proper

renovatebot/renovate#25508
Isawan added a commit to Isawan/terrashine that referenced this pull request Nov 2, 2023
This has been upstreamed to renovate proper

renovatebot/renovate#25508
Isawan added a commit to Isawan/terrashine that referenced this pull request Nov 3, 2023
jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants