Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use titles for more code blocks #25526

Merged
merged 6 commits into from Nov 2, 2023

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Use titles for more code blocks
  • Other small style fixes

Context

Change code blocks so they show the file name or description of the content.

Some introductory text for code blocks is too long or complex to put in the title="", so I did not change those. 馃槃

Read the Material for MkDocs, adding a title to code blocks to learn more, and to see an example.

Follow-up PR after:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Nov 1, 2023

How do these look when viewed in "preview" form on GitHub?

@HonkingGoose
Copy link
Collaborator Author

How do these look when viewed in "preview" form on GitHub?

GitHub does not show the title in the codeblock. So the published docs look better, but the "nice GitHub preview of the Markdown file" gets broken. When you view the raw file or go into the edit mode, you'll see the titles of course.

@rarkins
Copy link
Collaborator

rarkins commented Nov 1, 2023

@viceice @secustor wdyt?

@secustor
Copy link
Collaborator

secustor commented Nov 1, 2023

As long we only do it for user docs the broken preview is fine for me.

@rarkins rarkins added this pull request to the merge queue Nov 2, 2023
Merged via the queue into renovatebot:main with commit b583229 Nov 2, 2023
36 checks passed
@HonkingGoose HonkingGoose deleted the docs/title-codeblocks branch November 2, 2023 17:08
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 37.43.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants