feat(manager/dockerfile): Add syntax statement support #25530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Nov 1, 2023
viceice
changed the title
viceice
reviewed
Nov 1, 2023
viceice
approved these changes
Nov 5, 2023
auto-merge was automatically disabled
November 6, 2023 17:12
Head branch was pushed to by a user without write access
viceice
reviewed
Nov 6, 2023
Simpler solution Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
Nov 7, 2023
…-syntax-statement' into feat/docker-support-syntax-statement
viceice
reviewed
Nov 9, 2023
Co-authored-by: Johannes Feichtner <343448+Churro@users.noreply.github.com>
viceice
approved these changes
Nov 10, 2023
Churro
approved these changes
Nov 10, 2023
|
🎉 This PR is included in version 37.55.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi, is there a way to prevent renovate from making these changes? I can't figure it out based on docs and source code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for the syntax directive as requested in #22804, added a unittest and changed an existing test that included a syntax directive.
Context
I want to do some more contributions, but since I'm quite new in TS development I wanted to start with a "Good first issue".
Closes #22804
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: