Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kustomize): support image digest pinning in newTag #25596

Merged

Conversation

maxbrunet
Copy link
Contributor

Changes

Add autoReplaceStringTemplate to images with newTag, which in my opinion, is the only case where it is clearly desired to enable digest pinning.

Context

Like #24942, without autoReplaceStringTemplate, this was blocking the renovate/pin-dependencies branch

This is not the full support as investigated in #24767.

Mainly, even while following the current limitations, it is unclear what the intent is when newName is used:

  • is it set to use a different mirror and the image version is set in the manifest
  • or is it meant to use an entirely different image, in which case, digest pinning may be desirable

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title fix(kustomize): support image digest pinning in newTag feat(kustomize): support image digest pinning in newTag Nov 6, 2023
@rarkins rarkins added this pull request to the merge queue Nov 6, 2023
Merged via the queue into renovatebot:main with commit 5674887 Nov 6, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants