Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prettier): Force trailing commas #25631

Merged

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 7, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Nov 7, 2023
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we have 1123 files changed here while only 51 files changed in the prettier v3 PR? If they loosened their "all" logic in v3 then it would be a mistake to touch all these files now unnecessarily

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 7, 2023

Just checked, it's 1117 in v3 branch

rarkins
rarkins previously approved these changes Nov 7, 2023
auto-merge was automatically disabled November 7, 2023 15:30

Head branch was pushed to by a user without write access

@zharinov zharinov dismissed stale reviews from rarkins and viceice via be754c7 November 7, 2023 15:30
@zharinov zharinov requested a review from rarkins November 7, 2023 15:30
@zharinov zharinov marked this pull request as draft November 7, 2023 15:34
@zharinov zharinov marked this pull request as ready for review November 7, 2023 15:34
@rarkins rarkins added this pull request to the merge queue Nov 7, 2023
Merged via the queue into renovatebot:main with commit b69416c Nov 7, 2023
65 of 80 checks passed
@rarkins rarkins deleted the refactor/prettier-trailing-comma-all branch November 7, 2023 16:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.50.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants