Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First letter of onboardingCommitMessage is converted to lowercase although "commitMessageLowerCase" is set to "never" #25662

Open
rarkins opened this issue Nov 9, 2023 Discussed in #25625 · 0 comments
Labels
core:onboarding Related to the onboarding process priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 9, 2023

Discussed in #25625

Originally posted by mkrill November 7, 2023

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

Gitlab

If you're self-hosting Renovate, select which platform you are using.

GitLab self-hosted

Was this something which used to work for you, and then stopped?

I am trying to get this working for the first time

Describe the problem

Hello,
in our onboarding configuration in config.js file , we try to initialize our onboardingCommitMessage like so DIGIHUB-123456 configure Renovate.

However, although having configured semanticCommits: "enabled" and commitMessageLowerCase: "never" in config.js, the resulting commit message in the onboarding branch is chore(deps): dIGIHUB-223277 configure Renovate. Thus, instead of starting with uppercade D, it starts with lowercase d. This breaks our push rule for commit messages.

I am not a typescript person, but the commit responsible for this bug seems to be ed73d38 and more concrete the following function https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/model/commit-message.ts#L71

IMO, there shouldn't be any lowercase conversion, if commitMessageLowerCase is set to "never".

I will add a reproduction repository as soon as I find the time to setup a corresponding GitHub repo.

Relevant debug logs

Logs
Copy/paste the relevant log(s) here, between the starting and ending backticks

Have you created a minimal reproduction repository?

https://github.com/renovate-reproductions/nvm3

@rarkins rarkins added type:bug Bug fix of existing functionality priority-4-low Low priority, unlikely to be done unless it becomes important to more people core:onboarding Related to the onboarding process labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:onboarding Related to the onboarding process priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant