fix(pre-commit): Gitlab Custom RegistryUrl not honored

[gone-for-coding]

Changes

The pre-commit manager does not return custom registryUrls to the gitlab-tags datasource which then always defaults to gitlab.com.

This PR always returns a registryUrl back to the datasource which fixes the behaviour. The tests have been edited accordingly to pass.

Context

Fixes #25157

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[CLAassistant]

All committers have signed the CLA.

[rarkins]

I'd like to understand why other parts of this function return registryUrls: [hostname] and it seems to work. I had though that registryUrls must start with https:// so wonder if they're being massaged somewhere else

[gone-for-coding]

Yes, the https:// prefix ist stripped here:

renovate/lib/modules/manager/pre-commit/extract.ts

Line 83 in 9a55d75

regEx('^https?://(?<hostname>[^/]+)/(?<depName>\\S*)'),

So I readd it as the gitlab-tags datasource seems to require the https:// prefix to work properly.

Regarding the other parts of the function which return registryUrls, they have the https:// prefix as it is added here:

renovate/lib/modules/manager/pre-commit/extract.ts

Line 39 in 9a55d75

const hostUrl = 'https://' + hostname;

As the function already returns before line 39 I needed to add it.

Currently I'm wondering if anything below line 39 is actually every executed.

[viceice]

LGTM but you need to fix the git author and then force push changes

[renovate-release]

🎉 This PR is included in version 37.57.1 🎉

The release is available on:

• GitHub release
• 37.57.1

Your semantic-release bot 📦🚀