Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/custom): allow to fetch from YAML data endpoint #25695

Merged
merged 4 commits into from Nov 13, 2023

Conversation

nSimonFR
Copy link
Contributor

@nSimonFR nSimonFR commented Nov 10, 2023

Changes

feat(datasource/custom): allow to fetch from YAML data endpoint

Context

Closes #25634

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link

@maximeancellin maximeancellin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! ✅

lib/config/types.ts Outdated Show resolved Hide resolved
lib/modules/datasource/custom/formats/yaml.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

lib/modules/datasource/custom/formats/yaml.ts Outdated Show resolved Hide resolved
lib/modules/datasource/custom/index.spec.ts Outdated Show resolved Hide resolved
@secustor
Copy link
Collaborator

Also needs prettier-fix

lib/modules/datasource/custom/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/custom/readme.md Outdated Show resolved Hide resolved
@secustor secustor added this pull request to the merge queue Nov 13, 2023
Merged via the queue into renovatebot:main with commit 53401eb Nov 13, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -118,6 +118,39 @@ When Renovate receives this response with the `plain` format, it will convert it

After the conversion, any `jsonata` rules defined in the `transformTemplates` section will be applied as usual to further process the JSON data.

### Yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at h4 instead of h3 to be on the same as JSON and plain.

Line 13 misses yaml as a valid option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to open a PR to fix it 🤗

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(datasource/custom): allow to fetch from YAML data endpoint
6 participants