Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure Renovate PR check fails to create PR comment #25754

Closed
rarkins opened this issue Nov 14, 2023 · 2 comments · Fixed by #25954
Closed

Reconfigure Renovate PR check fails to create PR comment #25754

rarkins opened this issue Nov 14, 2023 · 2 comments · Fixed by #25954
Assignees
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 14, 2023

Describe the proposed change(s).

On GitHub, Renovate fails to find the PR associated with the renovate/reconfigure branch, because the author is not Renovate Bot and we retrieve only PRs by Renovate's username.

Same problem may occur on other platforms too.

We probably don't want to fetch all PRs by every author, although maybe we need to fetch all open PRs plus all closed ones by Renovate. Alternatively maybe there's a way to efficiently find just one (open) PR for a particular branch?

Related discussion: #25721

@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:config Related to config capabilities and presets labels Nov 14, 2023
@RahulGautamSingh
Copy link
Collaborator

It is possible to look for PRs open from a particluar branch using Gitlab and Github API but Gitea still has no such support (related issue)

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 21, 2023

Shouldn't be necessary. For Gitea we already fetch every single PR and then do filtering by author on the client side:

if (createdBy && botUserName && createdBy !== botUserName) {
return null;
}

Therefore it's possible to save the whole list and/or specifically the reconfigure branch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants