Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(galaxy-collection): return sourceUrl of highest_version in getReleases() #25769

Merged
merged 1 commit into from Nov 14, 2023

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Nov 14, 2023

Changes

This PR finds the highest (as determined by galaxy-collection) version and uses the sourceUrl of this version as the overall package version.

In the tests the version is adjusted from 2.0.1 to 1.2.1 as that is the highest mocked result.

Context

Fixes #25767
Fixes #25768

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor added this pull request to the merge queue Nov 14, 2023
Merged via the queue into renovatebot:main with commit 786f4e8 Nov 14, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.59.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible-galaxy/galaxy-collection: sourceUrl is missing
3 participants