Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab): increase merge request status check timeout to 300 sec #25953

Conversation

fullstackcreatives
Copy link
Contributor

Changes

Increase retry times to 35 when requesting merge request status from gitlab when platform automerge is enabled.

Context

In some self-hosted Gitlab installation with self-hosted Gitlab Runners and a lot of workload most of the times pipelines need more than the very short timeout set before (7.5 sec) to be created when creating a MR. This results in 405 Method not allowed failure responses when trying to set a merge request to auto-merge. Increasing the timeout to a large enough number solves this issue. See discussion in this issue:

Closes #25946

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Nov 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2023
@rarkins rarkins added this pull request to the merge queue Nov 24, 2023
Merged via the queue into renovatebot:main with commit 3228c12 Nov 24, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.68.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice changed the title feat: increase gitlab merge request status check timeout to 300 sec feat(gitlab): increase merge request status check timeout to 300 sec Nov 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants