Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitlab): reduce attempts #25994

Merged
merged 1 commit into from Nov 28, 2023
Merged

fix(gitlab): reduce attempts #25994

merged 1 commit into from Nov 28, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 27, 2023

Changes

reduce attempts because 35 attempts would cause a delay of ~87 minutes. 8 attempts cause a delay of 5 min

Context

regression of

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins November 27, 2023 21:36
@fullstackcreatives
Copy link
Contributor

8 tries would result in 18000 ms so 18 seconds. The increase is not exponential but adds additional 500 ms to each step.

8 tries: 500 + 1000 + 1500 + 2000 + 2500 + 3000 + 3500 + 4000 = 18000

This means: 35 tries is appr. 5 min.

@rarkins rarkins added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 802f86d Nov 28, 2023
36 checks passed
@rarkins rarkins deleted the viceice-patch-1 branch November 28, 2023 05:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.71.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fullstackcreatives
Copy link
Contributor

PLEASE reconsider of reverting this: This is not 5 min timeout but 18 sec. This will cause most of our renovate runs fail to enable automerge.

@viceice
Copy link
Member Author

viceice commented Nov 28, 2023

PLEASE reconsider of reverting this: This is not 5 min timeout but 18 sec. This will cause most of our renovate runs fail to enable automerge.

I'll raise the backoff time instead otherwise renovate is hammering the API too much.

I'll do 500*attempt*attempt, so we've a quadratic wait time, which makes much more sense.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants