Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keep-alive): use camlcase for option name #26018

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix(keep-alive): use camlcase for option name #26018

merged 3 commits into from
Nov 28, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 28, 2023

Changes

  • rename keepalive to keepAlive
  • rename file keepalive to keep-alive

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title fix(keep-alive): use camlcase for keepalive options fix(keep-alive): use camlcase for option name Nov 28, 2023
@viceice viceice added this pull request to the merge queue Nov 28, 2023
HonkingGoose
HonkingGoose suggested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the PR title!

Merged via the queue into main with commit 8c78b5a Nov 28, 2023
36 checks passed
@viceice viceice deleted the fix/keep-alive-rename branch November 28, 2023 23:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.74.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use camelcase for keepalive config option
4 participants
@viceice @renovate-release @secustor @HonkingGoose