Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates): use re2 for replace helper #26019

Merged
merged 1 commit into from Nov 29, 2023
Merged

fix(templates): use re2 for replace helper #26019

merged 1 commit into from Nov 29, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 28, 2023

Changes

Use re2 for replace template helper

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

secustor
secustor reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking users with look backs, we should move this to the next major.

@viceice viceice changed the title fix(templates): use re2 for replace helper fix(templates)!: use re2 for replace helper Nov 28, 2023
@viceice viceice added the breaking Breaking change, requires major version bump label Nov 28, 2023
rarkins
rarkins reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non breaking?

@viceice viceice removed the breaking Breaking change, requires major version bump label Nov 28, 2023
@viceice viceice changed the title fix(templates)!: use re2 for replace helper fix(templates): use re2 for replace helper Nov 28, 2023
@viceice viceice added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 28, 2023
@viceice viceice added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 6af2be7 Nov 29, 2023
37 checks passed
@viceice viceice deleted the fix/re2-for-handlebars-helper branch November 29, 2023 01:36
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.74.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@secustor secustor secustor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viceice @renovate-release @rarkins @secustor