Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tekton): support pipelinesascode annotation #26033

Merged

Conversation

fabian-heib
Copy link
Contributor

@fabian-heib fabian-heib commented Nov 29, 2023

Changes

Add support for tekton pipelineascode annotations.

Context

This pull request introduces support for Tekton PipelinesAsCode annotation within Renovate. Tekton PipelinesAsCode is an emerging practice in Tekton where pipeline definitions are managed as code in a version-controlled repository. This enhancement enables Renovate to intelligently manage dependencies within Tekton PipelinesAsCode configurations. Docs on PipelinesAsCode.

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: https://github.com/fabian-heib/stakater-nordmart-review-api/pulls

@fabian-heib fabian-heib marked this pull request as ready for review November 30, 2023 13:58
lib/modules/manager/tekton/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/types.ts Outdated Show resolved Hide resolved
Follow best-practices for Renovate
Use record instead of object for annotation
Update annotation key filter based on how it is implemeted in PipelinesAsCode
lib/modules/manager/tekton/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Dec 1, 2023
@rarkins rarkins changed the title feat: support tekton pipelinesascode annotation feat(tekton): support pipelinesascode annotation Dec 2, 2023
lib/modules/manager/tekton/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/tekton/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/tekton/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/tekton/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify regex handling

lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/tekton/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice December 5, 2023 13:43
@viceice
Copy link
Member

viceice commented Dec 5, 2023

you need to resolve discussions 😉

@viceice viceice added this pull request to the merge queue Dec 5, 2023
Merged via the queue into renovatebot:main with commit 8c17027 Dec 5, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.87.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants