Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(http): Separate search and apply of host rules #26067

Merged
merged 3 commits into from
Dec 1, 2023
Merged

refactor(http): Separate search and apply of host rules #26067

merged 3 commits into from
Dec 1, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

  • Rename findMatchingRules to findMatchingRule
  • Rename applyHostRules to applyHostRule
  • Move findMatchingRule call out of the applyHostRule body
  • Refactor tests

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title refactor(http): Separate host rule search and apply refactor(http): Separate search and apply of host rules Nov 30, 2023
@zharinov zharinov mentioned this pull request Nov 30, 2023
Merged
6 tasks
rarkins
rarkins previously approved these changes Dec 1, 2023
View reviewed changes
@zharinov zharinov requested a review from viceice December 1, 2023 11:56
@viceice viceice added this pull request to the merge queue Dec 1, 2023
Merged via the queue into renovatebot:main with commit 383bc11 Dec 1, 2023
34 checks passed
@viceice viceice deleted the refactor/http-host-rule-search-apply-decouple branch December 1, 2023 12:10
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.80.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @renovate-release @viceice @rarkins