Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git): set submodule.recurse=true #26076

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(git): set submodule.recurse=true #26076

merged 1 commit into from
Dec 1, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 1, 2023

Changes

Set submodule.recurse=true when cloning submodules, so submodules are updated automatically when switching base branches.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 1, 2023 12:04
mtardy
mtardy approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sparks joy 🎉🤗

@viceice viceice added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 181c52f Dec 1, 2023
34 checks passed
@viceice viceice deleted the fix/git-submodules branch December 1, 2023 13:05
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.80.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Dec 6, 2023
@rarkins
Revert "fix(git): set submodule.recurse=true (#26076)"
53bc8d0 
This reverts commit 181c52f.
@rarkins rarkins mentioned this pull request Dec 6, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate does not update git submodules when changing branch
4 participants
@viceice @renovate-release @rarkins @mtardy