fix(helmfile): make resolving deps in multi-doc files more stable

[pathob]

Changes

Renovate doesn't manage to resolve dependencies anymore when there is a YAML document separator between repositories and releases. This is achieved by not continue'ing anymore when the document doesn't contain a releases block. Repositories that have potentionally been discovered in a document before are overriden (same as YAML would do).

Context

The Renovate dependency resolution breaks when a Helmfile contains a document separator between the repositories and the releases blocks. Using a document separator can be necessary when working with environments, as the following example Helmfile output shows:

$ helmfile -e qa template
Warning: environments and releases cannot be defined within the same YAML part. Use --- to extract the environments into a dedicated part
Warning: environments and releases cannot be defined within the same YAML part. Use --- to extract the environments into a dedicated part
...

Since these blocks are lists, they can not be extended in later documents. so e.g. a repositories list defined in the first document would completely be overridden by a repositories list in a later document (that's normal YAML behaviour). The Renovate manager should be adjusted to mimic this behaviour and properly support multi-document Helmfiles.

The following simple example from the Helmfile documentation can be used for reproducing the issue.

Before working:

environments:
  qa:
  staging:
  prod:

## document separator to satisfy Helmfile:
---

repositories:
 - name: prometheus-community
   url: https://prometheus-community.github.io/helm-charts

releases:
- name: prom-norbac-ubuntu
  namespace: prometheus
  chart: prometheus-community/prometheus
  ## Add a version to the example
  version: 25.7.0
  set:
  - name: rbac.create
    value: false

Before not working:

environments:
  qa:
  staging:
  prod:

repositories:
 - name: prometheus-community
   url: https://prometheus-community.github.io/helm-charts

## document separator to satisfy Helmfile:
---

releases:
- name: prom-norbac-ubuntu
  namespace: prometheus
  chart: prometheus-community/prometheus
  ## Add a version to the example
  version: 25.7.0
  set:
  - name: rbac.create
    value: false

With this PR, both variants are now working.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

Closes #26077

[rarkins]

Do we have any other cases where we parse multi-doc yaml files in a manager? I would like to compare the approaches in case there are any "gotchas" we've found elsewhere which should be ported here

[pathob]

Do we have any other cases where we parse multi-doc yaml files in a manager? I would like to compare the approaches in case there are any "gotchas" we've found elsewhere which should be ported here

@rarkins There are a few others, like Flux or Kubernetes, easy to find searching for parseYaml, but usually they work with YAML documents in a different way. For example Kubernetes expects a whole new manifest in each document, whereas in Helmfile these documents belong together.

[rarkins]

Most uses of parseYaml are for non multi-docs

[pathob]

@pathob Please do not force-push to your pull request branch. Read our contributing guide to learn more.

Yeah, I only did until the first review :)

[viceice]

just a small test thing

[renovate-release]

🎉 This PR is included in version 37.83.4 🎉

The release is available on:

• GitHub release
• 37.83.4

Your semantic-release bot 📦🚀