fix(git): set --recurse-submodules flag for checkout
#26163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Dec 6, 2023
viceice
reviewed
Dec 6, 2023
mtardy
force-pushed
the
pr/mtardy/fix-git-submodules
branch
from
63ae49b
to
518faca
Compare
|
Sorry I rebased and force pushed out of habit! |
viceice
previously approved these changes
Dec 6, 2023
|
this probably needs a new test case now |
viceice
previously approved these changes
Dec 7, 2023
|
I think my new test has side effects on the others, can you help me @viceice ? |
mtardy
force-pushed
the
pr/mtardy/fix-git-submodules
branch
from
eef24b5
to
c3e3412
Compare
My global config was setting the main branch to the name "main" while it's named "master" in the renovate CI, so this failed.
This allows to run setup and cleanup correctly on each tests and do not pollute other tests outcome if they fail.
|
I think my test is good enough now 🤠 |
viceice
approved these changes
Dec 8, 2023
|
🎉 This PR is included in version 37.89.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set
--recurse-submoduleswhen checking-out branches, so submodules are updated automatically when switching base branches.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: