fix(manager/git-submodules): Fix branch detection for special branch value .
#26329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--show-current is returning empty values.
viceice
reviewed
Dec 15, 2023
rarkins
approved these changes
Dec 16, 2023
|
🎉 This PR is included in version 37.100.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix branch detection due to GitSimple "--show-current" always returning empty values.
Changes
Use "--list" option instead of "--show-current" to get the name of the current branch.
Context
The current option was not working as expected, as it was always returning empty values :
{"all":[],"branches":{},"current":"","detached":false}Due to this, the detected branch was always an empty string when using the special branch value
.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: