Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning/loose): sort numeric parts numerically #26341

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Enabled the numeric option in String.localCompare method which comapres the suffix of the versions

Context

Closes: #26136

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

.vscode/settings.json Outdated Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Dec 17, 2023
Merged via the queue into renovatebot:main with commit d74fa61 Dec 17, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.102.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hersentino pushed a commit to hiventive/renovate that referenced this pull request Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loose versioning should sort numeric parts numerically
3 participants