Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/poetry): support git rev dependencies #26367

Merged
merged 9 commits into from Jan 4, 2024
Merged

feat(manager/poetry): support git rev dependencies #26367

merged 9 commits into from Jan 4, 2024

Conversation

NextFire
Copy link
Contributor

@NextFire NextFire commented Dec 19, 2023

Changes

This PR adds support for git dependencies identified by commit hash in Poetry:

yt-dlp = {git = "https://github.com/yt-dlp/yt-dlp.git", branch = "release", rev = "2325d03aa7bb80f56ba52cd6992258e44727b424"}

If specified, the branch marker is took into account, otherwise it defaults to HEAD (the default in GitRefsDatasource).

Context

Closes #21848 (?)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Repo example: https://github.com/NextFire/poetry-git-rev-renovate-repro (cowsay tracks HEAD while yt-dlp is updated to the latest commit of the release branch)

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is missing tests

lib/modules/manager/poetry/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/schema.ts Outdated Show resolved Hide resolved
auto-merge was automatically disabled December 21, 2023 16:57

Head branch was pushed to by a user without write access

@viceice viceice requested a review from secustor January 4, 2024 07:55
@viceice viceice removed the request for review from zharinov January 4, 2024 07:55
@viceice viceice enabled auto-merge January 4, 2024 07:55
@viceice viceice added this pull request to the merge queue Jan 4, 2024
Merged via the queue into renovatebot:main with commit 72fe67d Jan 4, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.121.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support git dependencies in Poetry manager
4 participants