Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matchConfidence): align supported datasources list with internal preset #26420

Merged
merged 9 commits into from Dec 27, 2023

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

Changes

The current implementation of the getConfidenceLevel function uses a hardcoded list of supported datasources. This list is used to filter requests to the backend, ensuring that only supported datasources result in an actual API call.
However, the current list is out of sync with the internal badges preset. In this PR, these two lists are combined into a single source of truth.

Additionally, an experimental feature flag has been added for internal use, allowing the overriding of the list for the getConfidenceLeve function.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title fix(matchConfidence): align supported datasources list with internal prese fix(matchConfidence): align supported datasources list with internal preset Dec 24, 2023
@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review December 24, 2023 22:53
lib/workers/global/initialize.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use the environment variable then the preset is again out of sync with the real config.

do we really need the configuration via environment?

lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
@nabeelsaabna
Copy link
Contributor

if you use the environment variable then the preset is again out of sync with the real config.

do we really need the configuration via environment?

  1. badges can be overridden by packageRules..
  2. The hardcoded list is tightly coupled to the production backend and only gets an updated after production backend is updated. We need a way to configure it for other non-production environments without changing/rebuilding the source.

lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry

lib/util/merge-confidence/index.spec.ts Outdated Show resolved Hide resolved
lib/util/merge-confidence/index.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti
Copy link
Collaborator Author

What prevents this from being merged 🤔?

@viceice
Copy link
Member

viceice commented Dec 27, 2023

needs @rarkins review 🤗

@viceice viceice added this pull request to the merge queue Dec 27, 2023
Merged via the queue into renovatebot:main with commit 84270be Dec 27, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.107.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
…preset (renovatebot#26420)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
…preset (renovatebot#26420)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
…preset (renovatebot#26420)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants