Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(renovate style guide): avoid manually ordering numbered lists #26445

Merged
merged 1 commit into from Dec 28, 2023

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Formally announce our rule about avoiding manually ordering numbered lists

Context

I just got a review request for a PR that makes a lot of changes to the ordered lists, those changes make it hard to review the PR.

We rely on the final renderer (GitHub or our published docs) to number the items. This way we can always move items around without worrying about messing up the previous ordering. 😄

Related PR with changes that I'd like to avoid in future:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added this pull request to the merge queue Dec 28, 2023
Merged via the queue into renovatebot:main with commit 53e1ca6 Dec 28, 2023
36 checks passed
@HonkingGoose HonkingGoose deleted the patch-1 branch December 28, 2023 11:13
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.110.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants