Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/go): Fixes splitting of gitlab go package name #26477

Merged
merged 14 commits into from Jan 10, 2024

Conversation

ManuelB
Copy link
Contributor

@ManuelB ManuelB commented Jan 2, 2024

Here is the corresponding discussion:
#26408

Changes

This will correctly split the registryUrl and the packageName of a go package.

Context

It is necessary to split a typical go modul into an url and a package name for gitlab.

e.g. example.com/gitlab/my-repo.git

registryUrl: example.com/gitlab/
packageName: my-repo

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ManuelB
Copy link
Contributor Author

ManuelB commented Jan 5, 2024

@rarkins I now implemented this in the way that you requested in: #26408

lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
ManuelB and others added 3 commits January 5, 2024 11:51
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@ManuelB
Copy link
Contributor Author

ManuelB commented Jan 5, 2024

@rarkins I fixed the prettier error:

vscode@6d06bfe1cec1:/workspaces/renovate$ git diff
diff --git a/lib/modules/datasource/go/base.spec.ts b/lib/modules/datasource/go/base.spec.ts
index b191d9d4c..e306ad6d1 100644
--- a/lib/modules/datasource/go/base.spec.ts
+++ b/lib/modules/datasource/go/base.spec.ts
@@ -412,7 +412,6 @@ describe('modules/datasource/go/base', () => {
           'example.com/gitlab/my-project/my-repo.git',
         );
 
-
         expect(res).toEqual({
           datasource: GitlabTagsDatasource.id,
           packageName: 'my-project/my-repo',
vscode@6d06bfe1cec1:/workspaces/renovate$ npx prettier --cache --check '**/*.{ts,js,mjs,json,md,yml}' "--cache-location" ".cache/prettier"
Checking formatting...
All matched files use Prettier code style!

lib/modules/datasource/go/base.spec.ts Show resolved Hide resolved
lib/modules/datasource/go/base.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/go/base.ts Outdated Show resolved Hide resolved
@ManuelB
Copy link
Contributor Author

ManuelB commented Jan 10, 2024

@rarkins I fixed the es-lint issue here: 0d11a38 can you rerun the build?

Do I have a possibility to check this locally?

@rarkins
Copy link
Collaborator

rarkins commented Jan 10, 2024

Yes, you can run pnpm run lint-fix locally to run all linting

@ManuelB
Copy link
Contributor Author

ManuelB commented Jan 10, 2024

$ pnpm run lint-fix
...
Linting: 239 file(s)
Summary: 0 error(s)

@ManuelB ManuelB requested a review from viceice January 10, 2024 09:56
@viceice viceice changed the title fix(gitlab): Fixes splitting of go package name fix(datasource/go): Fixes splitting of gitlab go package name Jan 10, 2024
@viceice viceice added this pull request to the merge queue Jan 10, 2024
Merged via the queue into renovatebot:main with commit 54a0233 Jan 10, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.128.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ManuelB
Copy link
Contributor Author

ManuelB commented Jan 10, 2024

@viceice & @rarkins thank you guys. You rock! 🎉

firke pushed a commit to firke/renovate that referenced this pull request Jan 12, 2024
…tebot#26477)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
…tebot#26477)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
…tebot#26477)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
…tebot#26477)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants