Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/nuget): Add autoReplaceStringTemplate #26508

Merged
merged 12 commits into from Jan 5, 2024

Conversation

marcmognol
Copy link
Contributor

@marcmognol marcmognol commented Jan 4, 2024

Changes

Support updating docker image digests for ContainerBaseImage property.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@marcmognol marcmognol marked this pull request as draft January 4, 2024 16:36
@marcmognol marcmognol marked this pull request as ready for review January 4, 2024 16:48
marcmognol and others added 2 commits January 5, 2024 11:49
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retain depType

lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/extract.spec.ts Show resolved Hide resolved
lib/modules/manager/nuget/extract.spec.ts Show resolved Hide resolved
viceice
viceice previously approved these changes Jan 5, 2024
@viceice viceice added the manager:nuget NuGeT (.NET) package manager label Jan 5, 2024
@marcmognol
Copy link
Contributor Author

@viceice Thank you for your help on this. Now builds are failing. Any idea?

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/extract.ts Outdated Show resolved Hide resolved
marcmognol and others added 2 commits January 5, 2024 12:28
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use batch apply for suggestions to only get one commit and one pipeline 😉

@viceice viceice enabled auto-merge January 5, 2024 11:29
@marcmognol
Copy link
Contributor Author

please use batch apply for suggestions to only get one commit and one pipeline 😉

Sorry ;)

@viceice viceice added this pull request to the merge queue Jan 5, 2024
Merged via the queue into renovatebot:main with commit b39ad3a Jan 5, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.125.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:nuget NuGeT (.NET) package manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants