New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(npm): use lockfileVersion from npm-shrinkwrap #26726
fix(npm): use lockfileVersion from npm-shrinkwrap #26726
Conversation
d0dc3e4
to
225cee8
Compare
01f37b4
to
98d69cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work if the lock file is in a subdirectory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should already know which lock file type is in use and not need to guess / try-catch-try
98d69cf
to
6ed3bdf
Compare
2619020
to
da90176
Compare
Head branch was pushed to by a user without write access
da90176
to
fac6938
Compare
🎉 This PR is included in version 37.140.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Read
lockfileVersion
fromnpm-shrinkwrap.json
file in case ofpackage-lock.json
missing.Context
In case of
npm-shrinkwrap.json
file is used and Node.js engine set inpackage.json
(with the version like>= 10.x
) wherenpm
version may be different than the one detected vs used to createnpm-shrinkwrap.json
, check thelockfileVersion
and use propernpm
version.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: